Skip to content

Make Project.category Optional #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make Project.category Optional #2649

wants to merge 2 commits into from
+102 −38

Conversation

@scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Nov 24, 2025

📲 What

A description of the change.

🤔 Why

Some background context on why the change is needed.

🛠 How

More in-depth discussion of the change or implementation.

👀 See

Trello, screenshots, external resources?

Before 🐛 After 🦋

♿️ Accessibility

  • Tap targets use minimum of 44x44 pts dimensions
  • Works with VoiceOver
  • Supports Dynamic Type

🏎 Performance

  • Optimized Blended Layers (screenshots)

✅ Acceptance criteria

  • Steps to test this feature
  • Environment to test on
  • Issues to look out for

⏰ TODO

  • Got planned refactors to come
  • Will add more tests
  • Need feedback on a design

@scottkicks scottkicks self-assigned this Nov 24, 2025
@scottkicks scottkicks force-pushed the scott/make-category-optional branch from c61c136 to 71677d8 Compare November 24, 2025 19:07
@scottkicks scottkicks force-pushed the scott/make-category-optional branch from 71677d8 to a748afb Compare November 24, 2025 19:10
@kickstarter kickstarter deleted a comment from nativeksr Nov 24, 2025
@nativeksr
Copy link
Collaborator

nativeksr commented Nov 24, 2025

SwiftLint found issues

Warnings

File Line Reason
Project+ProjectFragment.swift 462 File should contain 400 lines or less: currently contains 462 (file_length)
Project+ProjectFragment.swift 12 Function body should span 50 lines or less excluding comments and whitespace: currently spans 89 lines (function_body_length)
KSRAnalyticsTests.swift 272 Function body should span 50 lines or less excluding comments and whitespace: currently spans 60 lines (function_body_length)
ProjectLenses.swift 138 Closure body should span 30 lines or less excluding comments and whitespace: currently spans 34 lines (closure_body_length)
ProjectLenses.swift 410 Closure body should span 30 lines or less excluding comments and whitespace: currently spans 46 lines (closure_body_length)
DiscoveryPostcardViewModel.swift 154 Initializer body should span 50 lines or less excluding comments and whitespace: currently spans 99 lines (function_body_length)
DiscoveryPostcardViewModelTests.swift 430 File should contain 400 lines or less: currently contains 430 (file_length)
DiscoveryPostcardViewModelTests.swift 9 Class body should span 250 lines or less excluding comments and whitespace: currently spans 349 lines (type_body_length)
ThanksViewModel.swift 401 File should contain 400 lines or less: currently contains 401 (file_length)
ProjectPamphletMainCellViewModel.swift 497 File should contain 400 lines or less: currently contains 497 (file_length)
PledgeViewModelTests.swift 4467 Closure body should span 30 lines or less excluding comments and whitespace: currently spans 39 lines (closure_body_length)
PledgeViewModelTests.swift 4452 Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines (function_body_length)

Errors

File Line Reason
KSRAnalyticsTests.swift 2107 File should contain 1000 lines or less: currently contains 2107 (file_length)
KSRAnalyticsTests.swift 7 Class body should span 350 lines or less excluding comments and whitespace: currently spans 1683 lines (type_body_length)
ProjectLenses.swift 1328 File should contain 1000 lines or less: currently contains 1328 (file_length)
ProjectLenses.swift 22 Enum body should span 350 lines or less excluding comments and whitespace: currently spans 1070 lines (type_body_length)
ProjectPamphletMainCellViewModel.swift 137 Initializer body should span 100 lines or less excluding comments and whitespace: currently spans 112 lines (function_body_length)
PledgeViewModelTests.swift 4982 File should contain 1000 lines or less: currently contains 4982 (file_length)
PledgeViewModelTests.swift 16 Class body should span 350 lines or less excluding comments and whitespace: currently spans 4083 lines (type_body_length)

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@scottkicks scottkicks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottkicks @nativeksr